Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config: enable check #56315

Merged
merged 1 commit into from May 14, 2019
Merged

pkg-config: enable check #56315

merged 1 commit into from May 14, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 24, 2019

The pkg-config test suite does pass, except for 3 tests related to functionality
we've modified regarding Requires.private and --static.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Feb 24, 2019

CC @matthewbauer @vcunat @Ericson2314 do I have to do anything special for running test cases with cross compilation or bootstrapping here, or is the package as written OK?

@vcunat
Copy link
Member

vcunat commented Feb 24, 2019

I think it should be enough to check it builds on the three usual platforms.
@GrahamcOfBorg build pkgconfig

@Ericson2314
Copy link
Member

@bhipple the cross currently forces doCheck off accross the board, for better or worse, so you are fine.

The pkg-config test suite does pass, except for 3 tests related to functionality
we've modified regarding Requires.private and --static.
@Lassulus Lassulus merged commit 6d8b114 into NixOS:staging May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants