Change: [AzurePipelines] Use a minimum OSX version of 10.9 during building. #7275
Conversation
michicc
force-pushed
the
pr/azure_min_osx_ver
branch
from
dfe7939
to
c767826
Compare
|
Not sure this is the most practical place for this. If someone now builds it on his home computer, he might target the wrong OSX too. Wouldn't it be better to put this in the I have tried to avoid these specific things in the CI, as in my experience people have a harder time maintaining this. But I don't know how OSX does this normally, so this is an honest question :) |
There was a problem hiding this comment.
The commit message (first line) is wayyyyy too long :D. I would put the "as this is" in a new sentence in the body of the commit, as that gives you more room to explain why you do this. For example:
Change: [AzurePipelines] Use a minimum OSX version of 10.9 during building
As this is what the code supports, and michi_cc is going to explain in a few more words why we are doing this
| @@ -1,5 +1,5 @@ | |||
| steps: | |||
| - script: './configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig --enable-static' | |||
| - script: 'MACOSX_DEPLOYMENT_TARGET=10.9 ./configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig --enable-static' | |||
There was a problem hiding this comment.
Please put this in a parameters (see windows-build.yml). That way we can sync the '10.9' value between the files and instances. Than in azure-pipelines-ci.yml you can set the parameter for both build and dependencies; easier to spot they are equal. I think.
michicc
force-pushed
the
pr/azure_min_osx_ver
branch
2 times, most recently
from
f0eefa2
to
4436a44
Compare
…lding. OpenTTD sources are still written in a way to work down to OSX 10.4 or so, as long as you can obtain a C++11 capable compiler. 10.9 is the minimal useful C++11 target using only Apple stuff out-of-the-box.
michicc
force-pushed
the
pr/azure_min_osx_ver
branch
from
4436a44
to
e07e0f7
Compare
michicc
changed the title
OpenTTD sources are still written in a way to work down to OSX 10.4 or so, as long as you can obtain a C++11 capable compiler. 10.9 is the minimal useful C++11 target using only Apple stuff out-of-the-box.
This should not impact any current OSX versions and we don't necessarily need to change the website description. I just don't see a need to exclude users just because.