python.pkgs.pyqt5: 5.11.3 -> 5.12 #56354

dotlambda · 2019-02-25T15:39:40Z

Motivation for this change

Things done

dotlambda · 2019-02-25T15:42:50Z

Not yet ready for merge. I still have to investigate why running qutebrowser yields

qutebrowser needs QtWebKit or QtWebEngine, but neither could be imported!
The errors encountered were:
QtWebKit: cannot import name 'QtWebKit' from 'PyQt5' (/nix/store/5prasyaxrbcy43rdyq0zydgc1ap2l8dl-python3.7-pyqt-5.12/lib/python3.7/site-packages/PyQt5/__init__.py)
QtWebEngine: cannot import name 'QtWebEngineWidgets' from 'PyQt5' (/nix/store/5prasyaxrbcy43rdyq0zydgc1ap2l8dl-python3.7-pyqt-5.12/lib/python3.7/site-packages/PyQt5/__init__.py)

dotlambda · 2019-02-25T16:42:37Z

According to https://www.riverbankcomputing.com/news/pyqt-512, "the QtWebEngine, QtWebEngineCore and QtWebEngineWidgets modules have been moved to a separate PyQtWebEngine package." I'm currently packaging that one.

dotlambda · 2019-02-25T16:57:16Z

Now I'm getting

Fatal error: PyQt5.QtQml is required to run qutebrowser but could not be imported! Maybe it's not installed?

The error encountered was:
No module named 'PyQt5.QtQml'

Please search for the python3 version of PyQt5.QtQml in your distributions packages, or see https://github.com/qutebrowser/qutebrowser/blob/master/doc/install.asciidoc

That's still true when merging #56349.

dotlambda · 2019-02-25T16:57:45Z

pkgs/development/python-modules/pyqtwebengine/default.nix

+    mkdir -p "$out/share/sip/PyQt5"
+
+    # FIXME: Without --no-dist-info, I get
+    #     unable to create /nix/store/yv4pzx3lxk3lscq0pw3hqzs7k4x76xsm-python3-3.7.2/lib/python3.7/site-packages/PyQtWebEngine-5.12.dist-info


I really don't see any configure option to fix this :(

FRidh · 2019-05-12T18:11:13Z

Could you rebase?

dotlambda · 2019-05-13T15:35:50Z

Done. Note there's a new version out. However, I currently don't have time to look into this any further or work on nixpkgs at all.

cizra · 2019-05-16T12:52:24Z

Build fails for me:

$ nix-build -A qutebrowser
these derivations will be built:
  /nix/store/hcddpixnf5r6nd5acy5b1n28v71kvsha-python3.7-pyqtwebengine-5.12.1.drv
  /nix/store/aaxagq1g99520rvspgdfa5qbcx8ihhn0-qutebrowser-1.6.2.drv
building '/nix/store/hcddpixnf5r6nd5acy5b1n28v71kvsha-python3.7-pyqtwebengine-5.12.1.drv'...
unpacking sources
unpacking source archive /nix/store/bqzynfhf1d6in4cdb1bc7ni9qi74j399-PyQtWebEngine_gpl-5.12.1.tar.gz
source root is PyQtWebEngine_gpl-5.12.1
setting SOURCE_DATE_EPOCH to timestamp 1553006662 of file PyQtWebEngine_gpl-5.12.1/sip/QtWebEngineWidgets/qwebengineview.sip
patching sources
configuring
Error: Make sure you have a working sip on your PATH or use the --sip argument
to explicitly specify a working sip.
builder for '/nix/store/hcddpixnf5r6nd5acy5b1n28v71kvsha-python3.7-pyqtwebengine-5.12.1.drv' failed with exit code 1
cannot build derivation '/nix/store/aaxagq1g99520rvspgdfa5qbcx8ihhn0-qutebrowser-1.6.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/aaxagq1g99520rvspgdfa5qbcx8ihhn0-qutebrowser-1.6.2.drv' failed

veprbl · 2019-05-16T15:02:11Z

pkgs/development/python-modules/pyqtwebengine/default.nix

+  format = "other";
+
+  src = fetchurl {
+    url = "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-${version}.tar.gz";


nix-prefetch-url "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-5.12.tar.gz" [0.0 MiB DL] error: unable to download 'https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-5.12.tar.gz': HTTP error 404

Suggested change

url = "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-${version}.tar.gz";

url = "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/${version}/PyQtWebEngine_gpl-${version}.tar.gz";

That, and version 5.12 doesn't exist anymore — you need 5.12.1

It does:

nix-prefetch-url https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/5.12/PyQtWebEngine_gpl-5.12.tar.gz [0.0 MiB DL] path is '/nix/store/8wdwbx0vir0jkyfv4cnry1x1p1pd4625-PyQtWebEngine_gpl-5.12.tar.gz' 0j9zzgwrvh61mrzjfcdlhr08vg931ycb53ri51vynsj0grp07smn

Hah, the lack of version in path, compounded by the availability of the new version, tripped me up.

cizra · 2019-05-16T17:47:33Z

pkgs/development/python-modules/pyqt/5.x.nix

-  pname = "PyQt";
-  version = "5.11.3";
+  pname = "pyqt";
+  version = "5.12";


Suggested change

version = "5.12";

version = "5.12.1";

tadeokondrak · 2019-06-06T01:36:58Z

Now I'm getting
Fatal error: PyQt5.QtQml is required to run qutebrowser but could not be imported! Maybe it's not installed?

This can probably be fixed by adding more options into pkgs/development/python-modules/pyqt/5.x.nix. It depends on qtbase, but not qtdeclarative.

ghost · 2019-06-20T08:11:41Z

So I tried to contiue this by updating pyqt to 5.12.2 and pyqtwebengine to 5.12.1 since old versions are not available anymore. I can not make pyqtwebengine compile:
mkdir: cannot create directory \u2018/nix/store/4c4ajgdnhlqk994hilagk5cgv7vw9yzg-python3-3.7.3/lib/python3.7/site-packages/PyQt5\u2019: Permission denied
I've had some really annoying bugs in qutebrowser lately, which is why I really want this update, so I can see if the mismatched pyqt version is at fault.

FRidh · 2019-08-03T09:59:28Z

I'm taking this further in #65836.

dotlambda requested a review from veprbl February 25, 2019 15:39

dotlambda requested a review from FRidh as a code owner February 25, 2019 15:39

dotlambda added the 2.status: work-in-progress label Feb 25, 2019

GrahamcOfBorg added the 6.topic: python label Feb 25, 2019

GrahamcOfBorg requested review from lovek323 and svanderburg February 25, 2019 16:23

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Feb 25, 2019

dotlambda force-pushed the pyqt-5.12 branch from 22b0551 to d0d9236 Compare February 25, 2019 16:56

dotlambda commented Feb 25, 2019

View reviewed changes

GrahamcOfBorg added the 8.has: package (new) label Feb 25, 2019

GrahamcOfBorg requested a review from jagajaga February 25, 2019 17:13

FRidh added this to the 19.09 milestone Apr 28, 2019

Robert Schütz added 4 commits May 13, 2019 17:32

python.pkgs.sip: 4.19.13 -> 4.19.14

4a7731c

python.pkgs.pyqt5: 5.11.3 -> 5.12

ad3525a

python.pkgs.pyqtwebenginge: init at 5.12

ec783fb

qutebrowser: add pyqtwebengine to propagatedBuildInputs

d3b6e82

dotlambda force-pushed the pyqt-5.12 branch from d0d9236 to d3b6e82 Compare May 13, 2019 15:34

veprbl mentioned this pull request May 14, 2019

qutebrowser's Qt version is out of sync #61492

Closed

veprbl reviewed May 16, 2019

View reviewed changes

cizra reviewed May 16, 2019

View reviewed changes

worldofpeace mentioned this pull request Jul 23, 2019

qutebrowser: 1.6.3 -> 1.7.0 #65150

Closed

10 tasks

FRidh self-assigned this Jul 24, 2019

averelld mentioned this pull request Jul 31, 2019

Calibre expression got broken recently #65313

Closed

FRidh closed this Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python.pkgs.pyqt5: 5.11.3 -> 5.12 #56354

python.pkgs.pyqt5: 5.11.3 -> 5.12 #56354

dotlambda commented Feb 25, 2019

dotlambda commented Feb 25, 2019

dotlambda commented Feb 25, 2019

dotlambda commented Feb 25, 2019 •

edited

dotlambda Feb 25, 2019

FRidh commented May 12, 2019

dotlambda commented May 13, 2019

cizra commented May 16, 2019

veprbl May 16, 2019

cizra May 16, 2019

veprbl May 16, 2019

cizra May 16, 2019

cizra May 16, 2019

tadeokondrak commented Jun 6, 2019

ghost commented Jun 20, 2019

FRidh commented Aug 3, 2019

	url = "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-${version}.tar.gz";
	url = "https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/${version}/PyQtWebEngine_gpl-${version}.tar.gz";

python.pkgs.pyqt5: 5.11.3 -> 5.12 #56354

python.pkgs.pyqt5: 5.11.3 -> 5.12 #56354

Conversation

dotlambda commented Feb 25, 2019

Motivation for this change

Things done

dotlambda commented Feb 25, 2019

dotlambda commented Feb 25, 2019

dotlambda commented Feb 25, 2019 • edited

dotlambda Feb 25, 2019

Choose a reason for hiding this comment

FRidh commented May 12, 2019

dotlambda commented May 13, 2019

cizra commented May 16, 2019

veprbl May 16, 2019

Choose a reason for hiding this comment

cizra May 16, 2019

Choose a reason for hiding this comment

veprbl May 16, 2019

Choose a reason for hiding this comment

cizra May 16, 2019

Choose a reason for hiding this comment

cizra May 16, 2019

Choose a reason for hiding this comment

tadeokondrak commented Jun 6, 2019

ghost commented Jun 20, 2019

FRidh commented Aug 3, 2019

dotlambda commented Feb 25, 2019 •

edited