New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7062: Remove ship max order distance. #7279
Conversation
…when pathfinding.
It is skipped when NPF is in use. It is trivial to work around by adding and removing dummy orders. It is mostly alleviated by the ship path cache in YAPF.
Ideally buoys should still be used but with this change there's no reason, from a player POV, to bother. So I'm not sure. |
Putting this on 1.10 since it pretty much requires #7245 to be sensible. I believe one of the major reasons for the max order distance is the original pathfinder. |
Perhaps I should split this into two PRs, one to revert the earlier change, and then the second to remove the distance checks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all the same set of changes, I don't see any need to split it any further than per-commit
I was thinking the first commit may be a backport candidate. |
It is skipped when NPF is in use.
It is trivial to work around by adding and removing dummy orders.
It is mostly alleviated by the ship path cache in YAPF.