Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luakit: 2017.08.10 → 2.1 #56292

Merged
merged 2 commits into from Mar 2, 2019
Merged

luakit: 2017.08.10 → 2.1 #56292

merged 2 commits into from Mar 2, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 24, 2019

Motivation for this change

Cleaned up the expression a bit.

As for the docgen requires, lua docs state:

To determine its path, require first checks the global variable LUA_PATH. If the value of LUA_PATH is a string, that string is the path. Otherwise, require checks the environment variable LUA_PATH. Finally, if both checks fail, require uses a fixed path (typically "?;?.lua", although it is easy to change that when you compile Lua).

Not sure why it does not work.

cc @lprndn @emmanuelrosa
cc @teto (#55747)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Feb 28, 2019

Is the docgen functional ? feel free to merge without waiting for my PR, I dont know when I will be able to fix things.

@jtojnar jtojnar merged commit aaca9c0 into NixOS:master Mar 2, 2019
@jtojnar jtojnar deleted the luakit branch March 2, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants