Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.Nikola: 8.0.1 -> 8.0.2 #56305

Merged
merged 1 commit into from Mar 1, 2019
Merged

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Feb 24, 2019

Motivation for this change

Upgrade Nikola.

I'm not sure which should be the base branch. I now used staging-next as I was advised in another pull request that I can use that as the base branch in order to avoid merge conflicts with that branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 24, 2019 16:15
@jluttine
Copy link
Member Author

Hmm.. Actually building fails, need to fix that..

@jluttine
Copy link
Member Author

Fixed. Now the build and nox-review succeed.

@dotlambda
Copy link
Member

No need to target staging-next in this case.

@FRidh FRidh changed the base branch from staging-next to master March 1, 2019 08:23
@FRidh FRidh merged commit 3944fa4 into NixOS:master Mar 1, 2019
@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 1, 2019
@FRidh FRidh self-assigned this Mar 1, 2019
@samueldr
Copy link
Member

@FRidh you self-assigned, that was for the port to stable, right? Anything more to do other than cherry-picking this?

@davidak davidak mentioned this pull request Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants