Change: [NPF] Add path cache for ships. #7272
Closed
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, const cast probably needs to go. |
|
const_cast removed |
|
Is this working? I'm not noticing any performance improvement. EDIT: I think it's a difference in how no path found is handled between YAPF and NPF. |
|
If you provide a savegame, I will look into it. |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to extend cached paths to ships and NPF.
I know const_cast is not a good way of doing it, but I don't have time to remove it now. If it is necessary, maybe in a few weeks...