Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pvlib: enable tests #56301

Merged
merged 1 commit into from Mar 1, 2019
Merged

pythonPackages.pvlib: enable tests #56301

merged 1 commit into from Mar 1, 2019

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade pvlib and also enable unit tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 24, 2019 14:42
@dotlambda
Copy link
Member

This will conflict with staging-next, let's wait until that is merged.

@jluttine
Copy link
Member Author

Should I create these pull request branches from some other branch to avoid such conflicts? What is the correct branch to start working on?

I found these guides but they didn't tell (or I missed it):

@dotlambda
Copy link
Member

You can rebase on staging-next if you want. However, I'd prefer not to merge this until #56200 is merged.

@FRidh
Copy link
Member

FRidh commented Mar 1, 2019

Please solve merge conflicts by rebasing onto master. When that's done we can cherry-pick also to stable.

@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 1, 2019
@jluttine
Copy link
Member Author

jluttine commented Mar 1, 2019

@FRidh Done. Now this isn't anymore a version bump but just enables the tests.

@jluttine jluttine changed the title pythonPackage.pvlib: 0.6.0 -> 0.6.1 pythonPackage.pvlib: enable tests Mar 1, 2019
@jluttine jluttine changed the title pythonPackage.pvlib: enable tests pythonPackages.pvlib: enable tests Mar 1, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pvlib python3.pkgs.pvlib

@dotlambda dotlambda merged commit eef6341 into NixOS:master Mar 1, 2019
@dotlambda
Copy link
Member

When that's done we can cherry-pick also to stable.

@FRidh Feel free to do so put I don't see a reason.

@FRidh
Copy link
Member

FRidh commented Mar 2, 2019

Now it's only tests it's perhaps not worth it.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jluttine @dotlambda @FRidh @samueldr @GrahamcOfBorg