Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.eth-utils: 1.2.1 -> 1.4.1 & pythonPackage.eth-typing: 1.3.0 -> 2.0.0 #56302

Merged
merged 2 commits into from Feb 26, 2019
Merged

pythonPackage.eth-utils: 1.2.1 -> 1.4.1 & pythonPackage.eth-typing: 1.3.0 -> 2.0.0 #56302

merged 2 commits into from Feb 26, 2019

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade Python package eth-utils.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 24, 2019 15:00
@jluttine jluttine changed the title pythonPackage.eth-utils: 1.2.1 -> 1.4.1 pythonPackage.eth-utils: 1.2.1 -> 1.4.1 & pythonPackage.eth-typing: 1.3.0 -> 2.0.0 Feb 24, 2019
@jluttine
Copy link
Member Author

Added upgrade of eth-typing to the same pull request.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python3Packages.eth-typing pythonPackages.eth-utils python3Packages.eth-utils

worldofpeace
worldofpeace previously requested changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit msg's should be
pythonPackages not pythonPackage

@worldofpeace worldofpeace dismissed their stale review February 26, 2019 17:52

resolved by reviewer

@worldofpeace worldofpeace merged commit 37ca1a1 into NixOS:master Feb 26, 2019
@worldofpeace
Copy link
Contributor

Darn didn't correct the pr title 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @worldofpeace @GrahamcOfBorg