Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: init at 5.6.0 #56379

Merged
merged 1 commit into from Feb 25, 2019
Merged

phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: init at 5.6.0 #56379

merged 1 commit into from Feb 25, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

Wasn't yet packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg build php71Packages.sqlsrv php72Packages.sqlsrv php73Packages.sqlsrv php71Packages.pdo_sqlsrv php72Packages.pdo_sqlsrv php73Packages.pdo_sqlsrv

@aanderse
Copy link
Member Author

@etu What do you think? Merge it in real quick before we freeze? 😄

@etu etu merged commit 18c70f9 into NixOS:master Feb 25, 2019
@etu
Copy link
Contributor

etu commented Feb 25, 2019

@aanderse Sneaky there! :-)

@aanderse aanderse deleted the php-sqlsrv branch February 25, 2019 21:44
@etu
Copy link
Contributor

etu commented Feb 26, 2019

@aanderse But we seem to have missed the window :(

@aanderse
Copy link
Member Author

@etu that's alright. This change is pretty low impact so I'll try for a 19.03 backport sometime after 19.03 is released.

Thanks again!

@etu etu mentioned this pull request Apr 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @etu @GrahamcOfBorg