Initialize python pyviz stack and intake #56303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costrouc
force-pushed
the
python-intake-init
branch
from
34a021d
to
070df8a
Compare
|
@GrahamcOfBorg build python3Packages.intake python3Packages.hvplot python2Packages.intake python2Packages.hvplot |
dotlambda
reviewed
Feb 24, 2019
costrouc
force-pushed
the
python-intake-init
branch
from
cbc8027
to
2e9959e
Compare
costrouc
requested review from
basvandijk,
Ericson2314,
infinisil,
matthewbauer,
peti and
ryantm
as code owners
costrouc
force-pushed
the
python-intake-init
branch
from
2e9959e
to
a29b0cd
Compare
dotlambda
requested changes
Feb 24, 2019
dotlambda
requested changes
Feb 24, 2019
dotlambda
removed request for
ryantm,
matthewbauer,
peti,
basvandijk,
Ericson2314 and
infinisil
costrouc
force-pushed
the
python-intake-init
branch
from
a29b0cd
to
87772a4
Compare
dotlambda
reviewed
Feb 24, 2019
costrouc
force-pushed
the
python-intake-init
branch
from
87772a4
to
93792ca
Compare
|
Requested changes made and ready for merge. |
|
Please make the changes suggested in #56303 (comment). |
costrouc
force-pushed
the
python-intake-init
branch
from
93792ca
to
93db3cf
Compare
|
@dotlambda changes made and I can verify that python-snappy built |
dotlambda
requested changes
Feb 24, 2019
costrouc
force-pushed
the
python-intake-init
branch
from
93db3cf
to
a93e1c4
Compare
|
@GrahamcOfBorg build pythonPackages.intake |
costrouc
force-pushed
the
python-intake-init
branch
from
a93e1c4
to
f6719ef
Compare
|
@GrahamcOfBorg build python2Packages.intake python3Packages.intake |
|
@GrahamcOfBorg build python2Packages.intake python3Packages.intake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Initially this PR was meant to include intake but their description of "Intake is a lightweight package for finding, investigating, loading and disseminating data". Turns out that it has a lot of dependencies... which I ended up adding holoviews, panel, and hvplot which will be great additions to the jupyter notebook workflow.
This PR additionally fixes #56276.This is already fixed in staging-next.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)