Skip to content

Initialize python pyviz stack and intake #56303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 1, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 24, 2019

Motivation for this change

Initially this PR was meant to include intake but their description of "Intake is a lightweight package for finding, investigating, loading and disseminating data". Turns out that it has a lot of dependencies... which I ended up adding holoviews, panel, and hvplot which will be great additions to the jupyter notebook workflow.

This PR additionally fixes #56276. This is already fixed in staging-next.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.intake python3Packages.hvplot python2Packages.intake python2Packages.hvplot

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Feb 24, 2019

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger
@costrouc costrouc changed the base branch from master to staging-next February 24, 2019 16:22
@costrouc
Copy link
Member Author

Requested changes made and ready for merge.

@dotlambda
Copy link
Member

Please make the changes suggested in #56303 (comment).

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger
@costrouc
Copy link
Member Author

@dotlambda changes made and I can verify that python-snappy built

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build pythonPackages.intake

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.intake python3Packages.intake

@dotlambda dotlambda changed the base branch from staging-next to master March 1, 2019 08:27
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2Packages.intake python3Packages.intake

@dotlambda dotlambda merged commit 7455307 into NixOS:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dask is broken due to pythonPackages.partd
4 participants