New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very long stalls during town generation #7274
Comments
town names are english |
most likely the town name generator running out of names. |
@SamuXarick found causes for this which aren't the name issue. Needs the issue updating, thanks. See #7250 (comment) |
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Feb 26, 2019
…owns with 0 population
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Feb 26, 2019
…owns with 0 population
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Feb 26, 2019
…towns with 0 population
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Feb 26, 2019
…ing towns with 0 population
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this issue
Feb 26, 2019
…acent tile ownership, not nearest town. The existing test performed badly with a large number of towns due to having to calculate the nearest town, and also by its nature assumed a bridge was built by the nearest town, leading to bridges of nearby large towns be removed incorrectly.
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this issue
Feb 26, 2019
… adjacent tile ownership, not nearest town. The existing test performed badly with a large number of towns due to having to calculate the nearest town, and also by its nature assumed a bridge was built by the nearest town, leading to bridges of nearby large towns be removed incorrectly.
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Mar 3, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this issue
Mar 11, 2019
… adjacent tile ownership, not nearest town. (OpenTTD#7284) This only affects failed town generation, as towns do not delete bridges under any other circumstances. The existing test performed badly with a large number of towns due to having to calculate the nearest town, and also by its nature assumed a bridge was built by the nearest town, leading to bridges of nearby large towns be removed incorrectly. If we gain the ability to quickly retrieve the correct town (which is _not_ the nearest town) from the bridge, this change should be reviewed.
SamuXarick
added a commit
to SamuXarick/OpenTTD
that referenced
this issue
Apr 14, 2019
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this issue
Apr 16, 2020
… adjacent tile ownership, not nearest town. (OpenTTD#7284) This only affects failed town generation, as towns do not delete bridges under any other circumstances. The existing test performed badly with a large number of towns due to having to calculate the nearest town, and also by its nature assumed a bridge was built by the nearest town, leading to bridges of nearby large towns be removed incorrectly. If we gain the ability to quickly retrieve the correct town (which is _not_ the nearest town) from the bridge, this change should be reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version of OpenTTD
1.9.0-beta2
Expected result
Don't take/stall too long
Actual result
Very long stalls during town generation
Steps to reproduce
Launch OpenTTD
Click Settings, set these settings:
Close window
Click New Game, set these values:
Click Generate
Notice the number of stalls occuring during Town generation, usually past 3500. The frequency keeps increasing and increasing...
The text was updated successfully, but these errors were encountered: