Avoid problematic test case of llvm6 on Android #56272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay to me. But the fact we even have to rebuild llvm at all for android is a problem. Llvm is built for every backend it supports so we should be able to use the llvm from the binary cache. |
This was referenced Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a test case in llvm, introduced by upstream in
llvm-mirror/llvm@12d09b0
checks the generated code for the string
and. When building with Android asthe target platform, this string shows up there, and the tail fails
(erroneously). So we disable this single unit test in this case (by deleting it).
Fixes #56156