Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-desktop: fix thumbnailing with missing fontconfig cache #56346

Merged
merged 1 commit into from Feb 25, 2019
Merged

gnome3.gnome-desktop: fix thumbnailing with missing fontconfig cache #56346

merged 1 commit into from Feb 25, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Feb 25, 2019 •
edited

Motivation for this change

#56174 updated gnome-desktop which broke thumbnailing due to the sandbox trying to mount a non-existing directory (/var/cache/fontconfig). We patch the script so it won't try mounting the directory when it doesn't exist.

Things done

Tested thumbnailing in eog and gnome-desktop.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 25, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Feb 25, 2019

Can this be upstreamed?

@hedning
Copy link
Contributor Author

hedning commented Feb 25, 2019

I would think so.

@hedning
Copy link
Contributor Author

hedning commented Feb 25, 2019

upstream MR: https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/34. Not sure if it's worth it to pull the patch from there?

@hedning
gnome3.gnome-desktop: fix thumbnailing with missing fontconfig cache
af9f9f5 
Also use @storeDir@ instead of hardcoded /nix/store
@hedning hedning force-pushed the gnome-desktop-fix-thumbnailing branch from ce64ba5 to af9f9f5 Compare February 25, 2019 17:57
@hedning
Copy link
Contributor Author

hedning commented Feb 25, 2019

MR landed upstream :) so changed things to fetchpatch so we'll easily catch it when upgrading.

@hedning hedning merged commit 9202c5a into NixOS:master Feb 25, 2019
@hedning hedning mentioned this pull request Feb 25, 2019
Merged
2 tasks
@hedning hedning deleted the gnome-desktop-fix-thumbnailing branch October 15, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @jtojnar @GrahamcOfBorg