Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes several broken python packages for python-unstable #56312

Merged
merged 7 commits into from Feb 25, 2019
Merged

Fixes several broken python packages for python-unstable #56312

merged 7 commits into from Feb 25, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

#55757

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc changed the title Fixes for broken python packages for python-unstable Fixes several broken python packages for python-unstable Feb 24, 2019
@costrouc costrouc changed the base branch from master to python-unstable February 24, 2019 22:26
@dotlambda dotlambda changed the base branch from python-unstable to staging-next February 24, 2019 22:46
@dotlambda
Copy link
Member

"depreciated" -> "deprecated"

@dotlambda dotlambda removed the request for review from ryantm February 24, 2019 22:47
dotlambda
dotlambda requested changes Feb 24, 2019
View reviewed changes
pkgs/development/python-modules/pint/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pynacl/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/shapely/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/shapely/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gidgethub/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gidgethub/default.nix Outdated Show resolved Hide resolved
@costrouc costrouc force-pushed the python-unstable branch 2 times, most recently from 36e5227 to be06dd7 Compare February 24, 2019 23:46
@dotlambda
Copy link
Member

Two further things that should be changed in your commit messages:

  • "depreciated" -> "deprecated"
  • pythonPackages.monty: 1.0.2 -> 1.0.4

@dotlambda
Copy link
Member

I did the changes myself. Please have a look at the changes I made to shapely.

@costrouc
Copy link
Member Author

@dotlambda looks good to me! Sorry didn't have time this morning to make the edits

@dotlambda dotlambda merged commit 0dbfd0e into NixOS:staging-next Feb 25, 2019
@dotlambda
Copy link
Member

Sorry didn't have time this morning to make the edits

No problem. Thank you very much for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @dotlambda @GrahamcOfBorg