Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carnix: 0.9.7 -> 0.9.8 #56314

Merged
merged 1 commit into from Feb 24, 2019
Merged

Carnix: 0.9.7 -> 0.9.8 #56314

merged 1 commit into from Feb 24, 2019

Conversation

P-E-Meunier
Copy link
Contributor

Motivation for this change

Carnix evolved a little bit since the last version, it now supports editions. The output is also slightly different, to allow for easier feature editing.

Moreover, this commit contains lots of updates to the documentation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build carnix

@ryantm ryantm merged commit d461adf into NixOS:master Feb 24, 2019
@Ekleog
Copy link
Member

Ekleog commented Jul 23, 2019

@P-E-Meunier Looks like you forgot to git add the “lots of updates to the documentation” in this PR? The nixpkgs manual appears to still now be blocked on an earlier version of carnix usage (pre-generate-nix & co subcommands)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants