Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: 0.5.2 -> 0.5.3 #54497

Merged
merged 1 commit into from Feb 8, 2019
Merged

solc: 0.5.2 -> 0.5.3 #54497

merged 1 commit into from Feb 8, 2019

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jan 23, 2019

Motivation for this change

New release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jan 23, 2019

I build this using nix-review. It seems that the hash doesn't match.

[asthma@dev:~/work/nixpkgs]$ nix-review pr 54497
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
pull/54497/head:refs/nix-review/1
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 7 (delta 5), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (7/7), done.
From https://github.com/NixOS/nixpkgs
+ 3a99772d07a...be1b20ba93f refs/pull/54497/head -> refs/nix-review/1  (forced
update)
$ git worktree add /home/asthma/.cache/nix-review/pr-54497/nixpkgs
8ee43e01fad4dc7578a99e8db0a02a5d62054f82
Preparing worktree (detached HEAD 8ee43e01fad)
Checking out files: 100% (18063/18063), done.
HEAD is now at 8ee43e01fad linux: 4.9.151 -> 4.9.152
$ git merge --no-commit be1b20ba93f3dfa643bf09e3979d35f9fc0464ed
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox
true -f /home/asthma/.cache/nix-review/pr-54497/build.nix
fixed-output derivation produced path
'/nix/store/yqsgrbwqglb46bj3zmrryspqqvvqj36z-source' with sha256 hash
'009kjyb3r2p64wpdzfcmqr9swm5haaixbzvsbw1nd4wipwbp66y0' instead of the expected
hash '1jq41pd3nj534cricy1nq6wgk4wlwg239387n785aswpwd705jbb'
cannot build derivation
'/nix/store/9ir2xb05sw42a32xfqr4sk1hb2bibdrs-solc-0.5.3.drv': 1 dependencies
couldn't be built
cannot build derivation
'/nix/store/kpbi3ly02x63l4izxicwmn0a3ii34x6c-python3.7-slither-analyzer-0.3.0.drv':
1 dependencies couldn't be built
cannot build derivation '/nix/store/ssms918830ly7w2gs0sh2xdqqvia4y6i-env.drv':
2 dependencies couldn't be built
[0 built (1 failed), 22 copied (294.0 MiB), 45.9 MiB DL]
error: build of '/nix/store/ssms918830ly7w2gs0sh2xdqqvia4y6i-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/54497
2 package failed to build:
slither-analyzer solc

No packages were successfully build, skip nix-shell
$ git worktree prune

 [asthma@dev:~/work/nixpkgs]$

@asymmetric
Copy link
Contributor Author

Which hash specifically?

❯ nix-prefetch-github ethereum solidity --rev v0.5.3
{
    "owner": "ethereum",
    "repo": "solidity",
    "rev": "v0.5.3",
    "sha256": "1jq41pd3nj534cricy1nq6wgk4wlwg239387n785aswpwd705jbb"
}

Not sure why it's trying to build slither-analyzer either. Maybe cause I'm the maintainer?

@asymmetric
Copy link
Contributor Author

@ivegotasthma you were right, the rev hadn't been updated, force-pushed.

@asymmetric
Copy link
Contributor Author

cc @akru @lionello

@lionello
Copy link
Contributor

lionello commented Feb 6, 2019

LGTM

@matthewbauer matthewbauer merged commit 961fbc3 into NixOS:master Feb 8, 2019
@asymmetric asymmetric deleted the solc-0.5.3 branch February 8, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants