Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptopenjdk: 11.0.1 -> 11.0.2 (x86_64-linux only) #54496

Merged
merged 1 commit into from Jan 25, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 23, 2019

Motivation for this change
  • Security fixes
  • Other updates

https://www.oracle.com/technetwork/java/javase/11-0-2-relnotes-5188746.html
https://www.oracle.com/technetwork/security-advisory/cpujan2019-5072801.html#AppendixJAVA

Updated the expressions and generate-sources.py to have different version numbers for each archs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jan 23, 2019

LGTM 👍 I built it with nix-review, are there any tests I can run?

@taku0
Copy link
Contributor Author

taku0 commented Jan 23, 2019

There is no test in nixpkgs for now. I tested binaries with a simple program showing AWT and Swing windows: https://github.com/taku0/JavaSample

@Mic92 Mic92 merged commit 8dd8698 into NixOS:master Jan 25, 2019
@veprbl veprbl changed the title adoptopenjdk: 11.0.1 -> 11.0.2 (x86_64-linux only) [Security fixes] adoptopenjdk: 11.0.1 -> 11.0.2 (x86_64-linux only) Jan 25, 2019
@hedning
Copy link
Contributor

hedning commented Jan 26, 2019

I think this broke the tarball build:

checking Nixpkgs on i686-linux
error: while evaluating the attribute 'handled' at /build/source/pkgs/stdenv/generic/check-meta.nix:252:7:
while evaluating 'handleEvalIssue' at /build/source/pkgs/stdenv/generic/check-meta.nix:146:28, called from /build/source/pkgs/stdenv/generic/check-meta.nix:253:14:
while evaluating the attribute 'name' at /build/source/pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix:50:3:
attribute 'i686' missing, at /build/source/pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix:51:54

@taku0
Copy link
Contributor Author

taku0 commented Jan 30, 2019

My understanding is that platforms doesn't contain i686-linux if it is not available in sources.json, so nix-build will refuse to start to build it. But the log shows that it tried to build the package, then failed to build it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants