Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thrift: fix build #53726

Merged
merged 2 commits into from Jan 10, 2019
Merged

thrift: fix build #53726

merged 2 commits into from Jan 10, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 10, 2019 •
edited

Motivation for this change

Fixes the build of thrift (and pycassa) by specifying proper constraints and adding missing dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.thrift: fix build
5338097 
Adds missing `six` dependency to the build inputs.

See also https://hydra.nixos.org/build/86094652
@Ma27 Ma27 requested a review from FRidh as a code owner January 10, 2019 01:50
@worldofpeace
Copy link
Contributor

The pin was to fix pycassa/pycassa#245.

@Ma27
Copy link
Member Author

Ma27 commented Jan 10, 2019

Although I can't reproduce the issue in the manual example with list_keyspaces with a local cassandra instance, I guess it's better to not break the constraint then. Should we simply override thrift in the pycassa expression accordingly?

@worldofpeace
Copy link
Contributor

Although I can't reproduce the issue in the manual example with list_keyspaces with a local cassandra instance, I guess it's better to not break the constraint then. Should we simply override thrift in the pycassa expression accordingly?

I think we should do that, though there's usually not much else we can do with these kind of issues.

@Ma27
pythonPackages.pycassa: fix build
642f778 
Use `thrift` 0.9.3 to build.

See also pycassa/pycassa#245
@Ma27
Copy link
Member Author

Ma27 commented Jan 10, 2019

@worldofpeace fixed and tested with a local cassandra instance. Anything else to add? :)

@worldofpeace
Copy link
Contributor

@worldofpeace fixed and tested with a local cassandra instance. Anything else to add? :)

Nope, looks great. Built it locally with success.

@worldofpeace worldofpeace merged commit 3bcd4f3 into NixOS:master Jan 10, 2019
@Ma27 Ma27 deleted the unbreak-thrift branch January 10, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @worldofpeace @GrahamcOfBorg