Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonfire: fix build #53725

Merged
merged 1 commit into from Jan 10, 2019
Merged

bonfire: fix build #53725

merged 1 commit into from Jan 10, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 10, 2019 •
edited

Motivation for this change

The build could be fixed by loosening the constraint for click (which
is currently at 7.0 in master). The CLI interface remains functional
with v7.

See also https://hydra.nixos.org/build/86455177

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
bonfire: fix build
d1227c8 
The build could be fixed by loosening the constraint for `click` (which
is currently at 7.0 in master). The CLI interface remains functional
with v7.

See also https://hydra.nixos.org/build/86455177
@worldofpeace worldofpeace merged commit ada7cf0 into NixOS:master Jan 10, 2019
@Ma27 Ma27 deleted the unbreak-bonfire branch January 10, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @worldofpeace @GrahamcOfBorg