Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termbox: fix build #53722

Merged
merged 1 commit into from Jan 11, 2019
Merged

termbox: fix build #53722

merged 1 commit into from Jan 11, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 10, 2019 •
edited

Motivation for this change

Applies a patch which fixes the waf build on Python 3.7.
See also https://hydra.nixos.org/build/86295267

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Jan 10, 2019

Pinging @fgaz, the maintainer of this package to test.

@Ma27
termbox: fix build
d50dacb 
Applies a patch which fixes the `waf` build on Python 3.7.
See also https://hydra.nixos.org/build/86295267
@worldofpeace
Copy link
Contributor

This fixes the build, but shouldn't a python module use buildPythonPackage?

Though that's outside the scope of this pr.

@Ma27
Copy link
Member Author

Ma27 commented Jan 10, 2019

I'd say no in this case. buildPython{Package.Application} is designed to create a Python package using setuptools to build. In this case waf is used. However I'm not entirely sure whether it fits into pythonPackages, but that's out of scope IMHO.

fgaz
fgaz approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fgaz
Copy link
Member

fgaz commented Jan 11, 2019

@Ma27

I'm not entirely sure whether it fits into pythonPackages

This only builds the C library, so no

@Mic92 Mic92 merged commit ce9bc1e into NixOS:master Jan 11, 2019
@Ma27 Ma27 deleted the fix-python37-on-termbox branch January 11, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@fgaz fgaz fgaz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @worldofpeace @fgaz @Mic92 @GrahamcOfBorg