Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashplayer: 32.0.0.101 -> 32.0.0.114 #53742

Merged
merged 2 commits into from Jan 13, 2019
Merged

flashplayer: 32.0.0.101 -> 32.0.0.114 #53742

merged 2 commits into from Jan 13, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 10, 2019

Motivation for this change
  • Low priority security update
  • Other performance fix

https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb19-01.html

flashplayer-standalone crashes with Application crashed with an unhandled SIGSEGV.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0
Copy link
Contributor Author

taku0 commented Jan 10, 2019

Fixes #53720.

@xeji xeji merged commit ec507f9 into NixOS:master Jan 13, 2019
xeji pushed a commit that referenced this pull request Jan 13, 2019
@taku0 @xeji
flashplayer-standalone: mark broken
ab476f6 
(cherry picked from commit a019087)
crashes, see #53742
@xeji
Copy link
Contributor

xeji commented Jan 13, 2019

backported to 18.09: 873a877 and ab476f6

@dywedir dywedir mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @xeji @vcunat @GrahamcOfBorg