New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHC 8.6 fixes and bound relaxation #53680
GHC 8.6 fixes and bound relaxation #53680
Conversation
@GrahamcOfBorg build haskell.packages.ghc844.beam-core |
08d8a9b
to
48bac25
Compare
@domenkozar I've re-pushed with fixed line endings in the patch files. Can you please ask ofborg to rebuild? (GHC 8.4.4 will fail because the fix that adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please report those issues upstream and add the appropriate ticket URLs into the source code next to the override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I spoke too early. I now noticed that most patches have an upstream ticket URL -- only the one for servant-docs
didn't. So never mind my previous comment.
However, could you please download the patches you've submitted in PRs from github rather than checking them into the Nixpkgs repository?
@peti Thanks for the review. I never filed an upstream bug for As for the beam patches, I think I can make that work. I'll need to fiddle patchFlags, though. |
Yes, that would be nice! |
Upstream doesn't publish releases or revisions to relax test bounds.
Upstream doesn't publish releases or revisions to relax test bounds.
48bac25
to
ed241de
Compare
@peti I have pushed a new branch with a new comment for servant-docs. I do not have time to re-do the patch files (which I had to assemble from a couple of places which I can't find right now). Is that a blocker for the merge? |
No, it's okay. Thank you very much for your efforts. I'll merge these changes into |
Motivation for this change
A haskell project I am working on cannot enter a nix-shell from nixpkgs master. This fixes some of the problems. Some problems are due to ghc 8.6 (e.g., the MonadFail fixes for beam) but some are due to version bounds that have become too tight.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)