Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scid-vs-pc: 4.18.1 -> 4.19 #53800

Merged
merged 1 commit into from Feb 7, 2019
Merged

scid-vs-pc: 4.18.1 -> 4.19 #53800

merged 1 commit into from Feb 7, 2019

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update and create desktop entry file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @paraseba

veprbl
veprbl reviewed Feb 2, 2019
View reviewed changes
pkgs/games/scid-vs-pc/default.nix Outdated Show resolved Hide resolved
pkgs/games/scid-vs-pc/default.nix Outdated Show resolved Hide resolved
pkgs/games/scid-vs-pc/default.nix Outdated Show resolved Hide resolved
@veprbl
Copy link
Member

veprbl commented Feb 2, 2019

cc @paraseba

@jfrankenau
Copy link
Member Author

@veprbl, thank you for your review. I’ve pushed the appropriate changes.

veprbl
veprbl approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veprbl veprbl merged commit 5704496 into NixOS:master Feb 7, 2019
@jfrankenau jfrankenau deleted the update-scid branch April 18, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @veprbl @GrahamcOfBorg