Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Adds patch for fixing wifi on raspberry pi #53747

Merged
merged 1 commit into from Jan 10, 2019
Merged

linux: Adds patch for fixing wifi on raspberry pi #53747

merged 1 commit into from Jan 10, 2019

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jan 10, 2019 •
edited

Motivation for this change

@kwohlfahrt here we go :)

Ping @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr
Copy link
Contributor Author

bkchr commented Jan 10, 2019

Okay, don't merge. Needs some resolving!

@bkchr bkchr force-pushed the raspberry_pi_wifi_fix_backport branch from 9fc6698 to 43f4fb3 Compare January 10, 2019 12:51
@bkchr
Copy link
Contributor Author

bkchr commented Jan 10, 2019

Okay fixed, I needed to adapt the patch to work with 4.19.

@Mic92 Mic92 merged commit 4d22e46 into NixOS:release-18.09 Jan 10, 2019
@bkchr bkchr deleted the raspberry_pi_wifi_fix_backport branch January 10, 2019 14:20
@Synthetica9
Copy link
Member

@bkchr A bit late, but where does this patch come from?

@Mic92
Copy link
Member

Mic92 commented Jan 10, 2019 •
edited

see #53694 (comment) for source

@Synthetica9
Copy link
Member

Why not use fetchPatch in that case?

@Mic92
Copy link
Member

Mic92 commented Jan 10, 2019 •
edited

The patch had to be changed slightly while backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @Synthetica9 @Mic92 @GrahamcOfBorg