Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash,readline80: upgrade bash 4 -> 5, init readline80 #53687

Closed
wants to merge 1 commit into from
Closed

bash,readline80: upgrade bash 4 -> 5, init readline80 #53687

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2019

Motivation for this change

Essentially same as #53628 only rebased to staging
and instead of (temporary?) top-level variants
go ahead and make it the default.

Naturally needs to be tested carefully first!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 9, 2019

This makes it the default, per your suggestion @Mic92 :).

Also looks like my concerns about breakage were warranted, our stdenv's consumeEntire seems not to work with this:

consumeEntire(): ERROR: Input null bytes, won't process

cc stdenv maintainers: @Ericson2314 @matthewbauer

@Mic92
Copy link
Member

Mic92 commented Jan 9, 2019

You might want to cherry-pick: 26c7c59

@Mic92
Copy link
Member

Mic92 commented Jan 17, 2019

Now this one can be rebased.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 20, 2019

See also #54353 FWIW.

@GrahamcOfBorg GrahamcOfBorg removed 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python labels Jan 20, 2019
@FRidh FRidh added this to the 19.09 milestone Apr 28, 2019
@FRidh
Copy link
Member

FRidh commented Apr 28, 2019

@dtzWill should this be closed?

@abathur abathur mentioned this pull request May 17, 2019
Open
@ttuegel ttuegel removed their request for review September 28, 2019 11:58
@FRidh
Copy link
Member

FRidh commented Nov 24, 2019

Nothing happening so closing.

@FRidh FRidh closed this Nov 24, 2019
@happysalada happysalada mentioned this pull request Aug 2, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @Mic92 @FRidh @GrahamcOfBorg