Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mercurial: 4.8.1 -> 4.8.2 #53684

Merged
merged 1 commit into from Jan 17, 2019
Merged

mercurial: 4.8.1 -> 4.8.2 #53684

merged 1 commit into from Jan 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2019

https://www.mercurial-scm.org/wiki/WhatsNew#Mercurial_4.8.2_.282018-01-07.29

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Jan 13, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you bump version, update pkgs.tortoisehg too or ping maintainer

@dtzWill
Copy link
Member Author

dtzWill commented Jan 13, 2019

if you bump version, update pkgs.tortoisehg too or ping maintainer

Dishonor on me, sorry for missing that. Looks like there's no tortoisehg released yet-- seems like path forward is to delay until tortoisehg makes a 4.8.2 release?

@FRidh
Copy link
Member

FRidh commented Jan 14, 2019

What do you think @danbst ?

@danbst
Copy link
Contributor

danbst commented Jan 14, 2019

yup, let's remove the comment. Now @ryantm 's bot does this job of updating tortoisehg.

@danbst
Copy link
Contributor

danbst commented Jan 17, 2019

oh, bot did update same thing #54170

@danbst danbst merged commit bfd31e2 into NixOS:master Jan 17, 2019
@danbst danbst mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @FRidh @danbst @GrahamcOfBorg