Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: 4.1.1 -> 4.2.1 #53673

Merged
merged 2 commits into from Jan 26, 2019
Merged

gitkraken: 4.1.1 -> 4.2.1 #53673

merged 2 commits into from Jan 26, 2019

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jan 8, 2019

Motivation for this change

Upgrade gitkraken to 4.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@megheaiulian megheaiulian changed the title gitkraken: 4.1.1 -> 4.2.0 gitkraken: 4.1.1 -> 4.2.1 Jan 25, 2019
@megheaiulian
Copy link
Contributor Author

@xeji Can you have a look ?

@etu
Copy link
Contributor

etu commented Jan 26, 2019

@GrahamcOfBorg build gitkraken

@etu etu merged commit fae5a99 into NixOS:master Jan 26, 2019
@megheaiulian megheaiulian deleted the feature/gitraken-4.2.0 branch January 28, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants