Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a deterministic seed for kernel RANDSTRUCT, and re-enable in hardened kernels #53802

Merged
merged 2 commits into from Jan 11, 2019
Merged

Use a deterministic seed for kernel RANDSTRUCT, and re-enable in hardened kernels #53802

merged 2 commits into from Jan 11, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jan 11, 2019

Motivation for this change

First step in addressing #53592. Does not allow users to configure their own seed just yet, but fixes the incompatibility issue with out-of-tree modules.

I think I'll attempt to contribute something upstream that adds an environment variable for users to inject a non-random RANDSTRUCT seed. I've looked through a few distros and everyone does it differently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
kernel: make the RANDSTRUCT seed deterministic
1b9bf8f
@delroth
Revert "Revert "Revert "linux-hardened: Disable GCC_PLUGIN_RANDSTRUCT"""
b26c824 
The issue with out-of-tree modules has been addressed and the feature
should now be good to re-enable again.

This reverts commit 865f7a1.
@delroth
Copy link
Contributor Author

delroth commented Jan 11, 2019

@joachifm @NeQuissimus

@joachifm
Copy link
Contributor

@GrahamcOfBorg test hardened

@joachifm
Copy link
Contributor

@GrahamcOfBorg build linux_hardened

@joachifm joachifm merged commit 11cd6ae into NixOS:master Jan 11, 2019
@NeQuissimus
Copy link
Member

Thank you for this :)

@delroth delroth mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @joachifm @NeQuissimus @GrahamcOfBorg