Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexyl: init at 0.3.0 #53728

Merged
merged 1 commit into from Jan 10, 2019
Merged

hexyl: init at 0.3.0 #53728

merged 1 commit into from Jan 10, 2019

Conversation

lilyball
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I left the maintainers empty as I don't particularly want to be on the hook for keeping this up-to-date. I'm hoping @dywedir will consent to maintain it as they already maintain the similar fd and bat packages by the same author.

@jb55
Copy link
Contributor

jb55 commented Jan 10, 2019

I was almost done packaging this xD. you people are too fast

@lilyball
Copy link
Member Author

It looks like the next version of hexyl will support Windows: sharkdp/hexyl#15

@lilyball
Copy link
Member Author

v0.3.1 is expected to be released tonight. I'll update this PR tomorrow unless a repo maintainer gets to it first.

@lilyball
Copy link
Member Author

Or I suppose this could be merged and a new PR opened for v0.3.1.

@dywedir
Copy link
Member

dywedir commented Jan 10, 2019 •
edited

Thank you!

@GrahamcOfBorg build hexyl

@dywedir dywedir merged commit 63ffed1 into NixOS:master Jan 10, 2019
@dywedir
Copy link
Member

dywedir commented Jan 10, 2019 •
edited 

v0.3.1

@sharkdp released this a minute ago

😄

@lilyball lilyball deleted the hexyl branch January 11, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lilyball @jb55 @dywedir @GrahamcOfBorg @Janik-Haag