New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opl3bankeditor, opn2bankeditor: init #53662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Jan 10, 2019
10 tasks
etu
requested changes
Feb 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some semantic suggestions
@GrahamcOfBorg build opl3bankeditor opl2bankeditor |
@etu Fixed, thank you! |
etu
reviewed
Feb 10, 2019
etu
approved these changes
Feb 10, 2019
@GrahamcOfBorg build opl3bankeditor opl2bankeditor |
@gnidorah Thanks! :-) |
@etu Thank you! |
ghost
deleted the
opl3bankeditor
branch
February 11, 2019 11:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A small cross-platform editors of the OPL3 and OPN2 FM banks of different formats
Useful for opl/opn synthesizers brought via separate PR
#53659
Project page https://github.com/Wohlstand/OPL3BankEditor
https://github.com/Wohlstand/OPN2BankEditor
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)