Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opl3bankeditor, opn2bankeditor: init #53662

Merged
merged 1 commit into from Feb 11, 2019
Merged

opl3bankeditor, opn2bankeditor: init #53662

merged 1 commit into from Feb 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2019

Motivation for this change

A small cross-platform editors of the OPL3 and OPN2 FM banks of different formats

Useful for opl/opn synthesizers brought via separate PR
#53659

Project page https://github.com/Wohlstand/OPL3BankEditor
https://github.com/Wohlstand/OPN2BankEditor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some semantic suggestions

pkgs/tools/audio/opl3bankeditor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/opl3bankeditor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/opl3bankeditor/opn2bankeditor.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/opl3bankeditor/opn2bankeditor.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor

etu commented Feb 10, 2019

@GrahamcOfBorg build opl3bankeditor opl2bankeditor

@ghost
Copy link
Author

ghost commented Feb 10, 2019

@etu Fixed, thank you!

@etu
Copy link
Contributor

etu commented Feb 11, 2019

@GrahamcOfBorg build opl3bankeditor opl2bankeditor

@etu etu merged commit 3e50fba into NixOS:master Feb 11, 2019
@etu
Copy link
Contributor

etu commented Feb 11, 2019

@gnidorah Thanks! :-)

@ghost
Copy link
Author

ghost commented Feb 11, 2019

@etu Thank you!

@ghost ghost deleted the opl3bankeditor branch February 11, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants