Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adlplug, opnplug: init at 1.0.0-beta.5 #53659

Merged
merged 1 commit into from Feb 10, 2019
Merged

adlplug, opnplug: init at 1.0.0-beta.5 #53659

merged 1 commit into from Feb 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2019 •
edited by ghost

Motivation for this change

Add FM Chip Synthesizers — OPL & OPN (used in MSDOS era sound cards and sega console)— VST/LV2/Standalone versions. A nice addition to distrho's JuceOPL we already have.

There are also instrument bank editors brought by separate PR #53662

Project page https://github.com/jpcima/ADLplug

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Jan 10, 2019
Merged
10 tasks
@etu
Copy link
Contributor

etu commented Feb 10, 2019

@GrahamcOfBorg build adlplug opnplug

@etu etu merged commit b8d7c0c into NixOS:master Feb 10, 2019
@etu
Copy link
Contributor

etu commented Feb 10, 2019

@gnidorah Thanks!

@ghost
Copy link
Author

ghost commented Feb 10, 2019

@etu Thank you! Could you please also look at #53662 which brings companion software?

@ghost ghost deleted the adlplug branch February 10, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @GrahamcOfBorg