Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pax: init at 0.4.0 #53660

Merged
merged 2 commits into from Jan 8, 2019
Merged

pax: init at 0.4.0 #53660

merged 2 commits into from Jan 8, 2019

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Jan 8, 2019

Motivation for this change

Pax is a JS bundler, see https://pax.js.org/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not sure if including Cargo.lock through Github Gists is a good idea, but it is done the same way at cargo-fuzz.

@veprbl
Copy link
Member

veprbl commented Jan 8, 2019

Seems like "pax" is a name commonly used for an archive tool: https://repology.org/metapackage/pax/versions

@klntsky
Copy link
Member Author

klntsky commented Jan 8, 2019

In AUR it is named pax-rs, is this name OK?

@klntsky
Copy link
Member Author

klntsky commented Jan 8, 2019 •
edited

By the way, the binary is named px for short, not pax. I hope it will not cause conflicts.

px is also taken...

veprbl
veprbl reviewed Jan 8, 2019
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/pax/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@klntsky
Copy link
Member Author

klntsky commented Jan 8, 2019

Also renamed the directory.

@veprbl
Copy link
Member

veprbl commented Jan 8, 2019

@GrahamcOfBorg build pax-rs

@veprbl veprbl merged commit c869fc2 into NixOS:master Jan 8, 2019
@veprbl
Copy link
Member

veprbl commented Jan 8, 2019

@8084 Congratulations on the first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klntsky @veprbl @GrahamcOfBorg @Janik-Haag