Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pycairo: 1.16.3 -> 1.18.0 #53792

Merged
merged 1 commit into from Jan 11, 2019

Conversation

worldofpeace
Copy link
Contributor

Changelog: https://pycairo.readthedocs.io/en/latest/changelog.html

Motivation for this change

They switched to meson, this expression looks a lot cleaner because of it.
Though I wonder if this will build for pypy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 403079a into NixOS:staging Jan 11, 2019
@worldofpeace worldofpeace deleted the pycairo/1.18.0 branch January 11, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants