Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exfat-nofuse: fix build for 4.18 #53699

Merged
merged 1 commit into from Jan 9, 2019
Merged

exfat-nofuse: fix build for 4.18 #53699

merged 1 commit into from Jan 9, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Jan 9, 2019 •
edited

Motivation for this change

additionally to fixing the build for linux 4.18 we use the PR 137 instead of the patch files from AUR.
This avoids changes in source files and pins the patch to exactly what we want
It also removes one fetchpatch call.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu
exfat-nofuse: fix build for 4.18
3034023 
additionally we use the PR 137 instead of the patch files from AUR.
This avoids changes in source files and pins the patch to exactly what we want
It also removes one fetchpatch call
@makefu
Copy link
Contributor Author

makefu commented Jan 9, 2019

@GrahamcOfBorg build linuxPackages-libre.exfat-nofuse linuxPackages.exfat-nofuse linuxPackages_4_14.exfat-nofuse linuxPackages_4_20.exfat-nofuse linuxPackages_4_4.exfat-nofuse linuxPackages_4_9.exfat-nofuse linuxPackages_hardened.exfat-nofuse linuxPackages_latest-libre.exfat-nofuse linuxPackages_latest_hardened.exfat-nofuse linuxPackages_latest_xen_dom0.exfat-nofuse linuxPackages_latest_xen_dom0_hardened.exfat-nofuse linuxPackages_testing_bcachefs.exfat-nofuse linuxPackages_testing_hardened.exfat-nofuse linuxPackages_xen_dom0.exfat-nofuse linuxPackages_xen_dom0_hardened.exfat-nofuse

@Mic92 Mic92 merged commit 2479e9e into NixOS:master Jan 9, 2019
@schmittlauch schmittlauch mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makefu @Mic92 @veprbl @GrahamcOfBorg