New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk3: fix segfaults when opening dialogs #53736
Conversation
Would it be viable to target master, it's a big (7000 all platforms combined) rebuild, but not massive? The bug is quite bad, crashing at least firefox, thunderbird and emacs reliably. |
For some reason the crashes don't happen to me (current master 829ada3; perhaps because of WM or something). Have you tested this really fixes the problems for you? |
I'm going off @Mic92's bug report, which matches the upstream issue well: https://gitlab.gnome.org/GNOME/gtk/issues/1523 I haven't tested it myself, but yeah, if it's not happening consistently staging is probably fine. |
So far no "luck" for me (no crash): I've tried xfwm4, xmonad, firefox, thunderbird, intel IGPU, AMD GPU. |
Should be fine to pass this through staging then, we can always fast forward it's needed later. |
In any case, you forgot to fix the copy-pasted hash ;-) |
Ouch, thanks. |
73540dc
to
f671ec8
Compare
Hydra's basically idle ATM, but let's compromise on |
That fixed the crash for me in emacs. |
OK. Plan: I hope staging-next will be found good-enough to merge very soon, during the weekend at latest. Rebuild in progress: https://hydra.nixos.org/eval/1499603?compare=1499579 If that fails, I believe we can cherry-pick this to master directly. |
Apply upstream fix.
closes #53697