[WIP] Build nixpkgs with gcc 8 by default #53760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Mic92
reviewed
Jan 10, 2019
Mic92
reviewed
Jan 10, 2019
fpletz
requested review from
edolstra,
infinisil,
nbp and
Profpatsch
as code owners
GrahamcOfBorg
added
6.topic: emacs
6.topic: GNOME
|
I see 172 commits, maybe you need to rebase this? |
|
I believe it's mainly because it got master commits that are missing from staging at this point. |
|
I've rebased this branch onto |
|
Let's aim for this right after the 19.03 branch off. We still have quite a few things in staging that I am wanting to prioritize. |
|
Sorry didn't mean to close it! |
|
Why the hell was f959c99 detected as merged to staging? It certainly doesn't seem reachable ATM. |
|
Well, GitHub still thinks it's merged and thus won't let me reopen in-place. Instead I opened #63132 so we don't lose the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps gcc used in
stdenvto version 8. The main motivation for this is the ability to add-fstack-clash-protectionto our default hardening flags (#53753). This will be done in a separate PR.I anticipate quite a few of broken packages because there are some new checks, i.e. for array bounds and format truncation.
There is also an old
gcc8branch which I noticed just now thanks to @Synthetica9. I'll cherry-pick changes from there.Hydra Job: https://hydra.nixos.org/jobset/nixpkgs/gcc8
Newly failing builds with gcc8: https://hydra.nixos.org/eval/1500732?compare=staging-next
Current state: Most packages seem to build.
clangsegfaults currently.gccfails on Darwin.