Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoreplace: better feedback for failed force-upgrade in depot #5776

Closed
DorpsGek opened this issue Oct 4, 2013 · 6 comments
Closed

Autoreplace: better feedback for failed force-upgrade in depot #5776

DorpsGek opened this issue Oct 4, 2013 · 6 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Oct 4, 2013

jvlomax opened the ticket and wrote:

A window will try to snap to a window that is not visible.

To reproduce: Set a wagon or train to autoreplace with another. Send trains to depot and press "Autoreplace all trains in depot" without having enough money to do so. No error is thrown, nothing happens
If I hold shift while pressing the button, it will give me an estimated cost

Expected behaviour: The game should tell me I don't have Enough Money

Actual behaviour: The action fails and the game does not tell me why

System info:
Windows 7
Openttd r25797 (downloaded precompiled binary)

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5776
@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 5, 2013

Alberth wrote:

Enable the vehicle news


This comment was imported from FlySpray: https://bugs.openttd.org/task/5776#comment12654

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 5, 2013

jvlomax wrote:

I know it shows in the news section, it's also in the news log. But I still think a red error message window should pop up explaining why it doesn't work.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5776#comment12655

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 6, 2013

Alberth wrote:

Yeah nice, every time an autoreplace fails throw an error message at the user.
Ever wondered what would happen if you do that when attempting (and failing) with 500+ trains running around?

I agree it could be more visible, but simply throwing an error message on failure is not the solution, I think.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5776#comment12656

@DorpsGek
Copy link
Member Author

andythenorth wrote:

The OP is suggesting this only triggers a message when the depot 'force upgrade' button is used. It took me literally years to learn what that button does, as most of the time, pressing it causes nothing to happen. A message specific to pressing that button does seem like a fair improvement to me. :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5776#comment14533

@DorpsGek DorpsGek added Autoreplace flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@andythenorth
Copy link
Contributor

See also #6207 which is a different cause, but needs similar message.

@andythenorth
Copy link
Contributor

Although this would be nice to have, it isn't something we expect to fulfill in the next year, and on that basis I'm closing it. We do this to keep the project manageable, productive and fun. We hope you do understand. Thanks for contributing though! Here you can find more about how we handle feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants