bear: fix wrapper detection patch by checking result of find_executable #53712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
With the wrapper detection patch, if a build invokes an executable that cannot be found in PATH by
find_executable
, bear will fail with anAttributeError
inos.path.realpath
.This can happen if the build invokes some project-local tool or command, like
./build-something
.Instead of calling using the result of
find_executable
directly, first check whether the executable was found and fall back to original Bear behavior if it was not.The problem can be easily reproduced like this, for example:
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)