Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio: add new optional dependencies #53780

Merged
merged 1 commit into from Jan 11, 2019
Merged

obs-studio: add new optional dependencies #53780

merged 1 commit into from Jan 11, 2019

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jan 10, 2019 •
edited by veprbl

Motivation for this change

Resolves #53779.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608
obs-studio: add new optional dependencies
26f7df6 
This commit adds a new set of optional dependencies introduced with version 21.0 of OBS to allow Lua and Python 3 scripts to be run.

If this batch of new dependencies is not desired by the user, then they may set `scriptingSupport` to false to disable it.
jb55
jb55 approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

vdemeester
vdemeester approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@Mic92
Copy link
Member

Mic92 commented Jan 11, 2019

@GrahamcOfBorg build obs-studio

@Mic92 Mic92 merged commit b4df112 into NixOS:master Jan 11, 2019
@OPNA2608 OPNA2608 deleted the obs-scripting branch April 27, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@puffnfresh puffnfresh puffnfresh approved these changes

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@OPNA2608 @Mic92 @vdemeester @puffnfresh @jb55 @GrahamcOfBorg