Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concourse #53691

Closed
wants to merge 33 commits into from
Closed

Concourse #53691

wants to merge 33 commits into from

Conversation

dingxiangfei2009
Copy link
Contributor

@dingxiangfei2009 dingxiangfei2009 commented Jan 9, 2019 •
edited

Motivation for this change

In this pull request, we provide Nix expression for evaluating concourse and fly, as well as systemd service units for setting up concourse ATC and/or worker.

Concourse: https://concourse-ci.org

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dingxiangfei2009
Copy link
Contributor Author

@GrahamcOfBorg build concourse

@dingxiangfei2009
Copy link
Contributor Author

@infinisil I have question about CI. It appears that CI refused to evaluate a derivation because the derivator was not in the store. How can I fix this problem?

@infinisil
Copy link
Member

Not sure what the problem is. In any case you should clean up the commits in this PR. This means:

  • One commit for adding yourself as a maintainer
  • A single commit for every package added
  • A single commit for every NixOS module added
  • Get rid of all merges, you should always rebase instead
  • Format your commit message according to the Contribution Guidelines, also linked to from the PR template.

dingxiangfei2009 and others added 17 commits April 10, 2019 23:03
@dingxiangfei2009
Linux concourse build (#1)
20b01bb 
* concourse: init at 4.3-unstable

* WIP

* add toplevl packages

* make concourse build on linux

* concourse: init at 4.3-unstable

* WIP

* add toplevl packages

* packr

* bump concourse version

* service definition

* change some defaults
@dingxiangfei2009
use fetchSubmodules instead of deepClone (#2)
11f4538
@dingxiangfei2009
support boolean flags
30bf6ba
@dingxiangfei2009
allow repeating arguments (#3)
1f00f17
@dingxiangfei2009
include /etc/{passwd,group,nsswitch.conf} into resources (NixOS#6)
b8f3e92
@dingxiangfei2009
add github-release and s3 resource types
c8836c2
@dingxiangfei2009
add libnss to elm runtime dependencies
5a95065
@dingxiangfei2009
bump concourse to next unstable master (NixOS#10)
4e166ef
@dingxiangfei2009
Separate concourse and fly (NixOS#11)
245f569 
* separate concourse and fly

* move preBuild commands out of buildConcourse

* different names for different derivations
@dingxiangfei2009
add metadata
be878d1
@dingxiangfei2009
add back preBuild hook
04b26cf
@dingxiangfei2009
fix sha for sonde-go
394e98b
@dingxiangfei2009
make garden and asset dir overridable
092b46f
@dingxiangfei2009
fix garden-bin type
2836341
@dingxiangfei2009
fix resource-types type
3a32cb1
@dingxiangfei2009
populate nix store database in resource images
53cbd33
@edude03 @dingxiangfei2009
update the concourse registry-image resource
6627492
This was referenced Apr 19, 2019
Closed
Closed
Closed
@dR3b
Copy link

dR3b commented Jul 2, 2019

When will concourse be available on the stable channel?

@dingxiangfei2009
Copy link
Contributor Author

@dR3b we are blocked on #60069 and #60071

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@pinpox
Copy link
Member

pinpox commented Mar 26, 2022

Any updates on this, is anyone working on adding concourse to nixos?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 26, 2022
@grerrg
Copy link

grerrg commented Apr 1, 2022

@pinpox
I'm looking forward to this one too.
Looks like the way to go is using the concourse docker container.

Since this issue is a bit older i've decided to go with buidbot because there are already nix options for that.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2022
@AndersonTorres
Copy link
Member

Closing as dead.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 3, 2023
@grerrg
Copy link

grerrg commented Jun 5, 2023

@dR3b we are blocked on #60069 and #60071

Can we somehow revive this since those blockers are resolved?
Could try my luck with those changes already present but haven't done much in this direction. -> could take some time.

@AndersonTorres
Copy link
Member

Do as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 6.topic: nixos 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dingxiangfei2009 @infinisil @dR3b @pinpox @grerrg @AndersonTorres @ryantm @GrahamcOfBorg @edude03