Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] rambox: update electron to 3.x #53692

Merged
merged 3 commits into from Jan 9, 2019
Merged

[backport] rambox: update electron to 3.x #53692

merged 3 commits into from Jan 9, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 9, 2019 •
edited

Motivation for this change

security security.
@mrVanDalo for testing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
electron_3: init at 3.1.0
f9f584c 
electron 4 had many breaking changes in their API,
breaking rambox. Since the 3.x version is still maintained,
we can add an older variant.

(cherry picked from commit 66c1f82)
@Mic92
rambox: downgrade electron to 3.x
6ccdd16 
(cherry picked from commit fdb87a0)
@mrVanDalo
Copy link
Contributor

looks good to me. I tested it via nix-review

@Mic92
electron_3: also update arm hashes
5838574 
(cherry picked from commit 60703db)
@Mic92
Copy link
Member Author

Mic92 commented Jan 9, 2019

@GrahamcOfBorg build rambox

@Mic92 Mic92 merged commit 23b9f34 into NixOS:release-18.09 Jan 9, 2019
@Mic92 Mic92 deleted the rambox-electron branch January 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @mrVanDalo @GrahamcOfBorg