Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: running the "rescannewgrf" command while newgrfs are already being scanned #6589

Closed
DorpsGek opened this issue Jul 17, 2017 · 6 comments
Labels
bug Something isn't working component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

james1101 opened the ticket and wrote:

Using Windows 7 Ultimate

When running the rescannewgrf command twice in quick succession, a game crash occurs.

To Reproduce: (Works best when the game has a lot of GRFs to scan.)
Run the rescannewgrf command twice in quick succession.

Suggested Fix: When attempting to run the rescannewgrf command while the newgrfs are already being scanned, it should, instead of restarting the scan and crashing, output "Error: Newgrfs still being scanned, please wait til it's finished.", "ERR_NEWGRF_ALREADY_BEING_SCANNED", "ERR_NEWGRF_SCAN_IN_PROGRESS" or something like that.

Attachments

Reported version: Version?
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6589
@DorpsGek
Copy link
Member Author

adf88 wrote:

"Run the rescannewgrf command twice in quick succession" - how are you doing this? Seems impossible from the in-game console thus I see no need for a full-blown, language-aware GUI error. It's rather a case of blocking/queuing/dropping calls to rescannewgrf properly. The in-game console (~) is already blocked when scan is in progress. It should be anyway - is it different at your side?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6589#comment14484

@DorpsGek
Copy link
Member Author

james1101 wrote:

I meant: Type 'rescannewgrf', then press the following in quick succession: Enter, Up arrow, Enter, Up arrow, Enter, ...


This comment was imported from FlySpray: https://bugs.openttd.org/task/6589#comment14485

@DorpsGek
Copy link
Member Author

adf88 wrote:

What version of OpenTTD are you using? Where did you get it?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6589#comment14486

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2017

james1101 wrote:

I meant to say OpenTTD 1.7.1, downloaded from the Openttd website.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6589#comment14487

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 2, 2017

adf88 wrote:

OK I see where's the problem now. At lest one of them. When newgrfrescan is in progress, hidden windows receive and process keyboard input (they shouldn't). So it is actually possible to run the command twice, even though you don't see it. It's a separate issue how commands are processed inside scripts tho.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6589#comment14488

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. At the time of writing this appears to be an isolated bug, and not frequently occurring. We do try to address bugs where they occur frequently and/or are easy to reproduce, but this one doesn't look like we can any go further, so I'm closing it. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants