Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purescript: fix build compiling with ghc 8.4.4 #53748

Merged
merged 1 commit into from Feb 21, 2019
Merged

purescript: fix build compiling with ghc 8.4.4 #53748

merged 1 commit into from Feb 21, 2019

Conversation

jacereda
Copy link
Contributor

Closes #53597.

Motivation for this change
Things done

Not sure this is the right thing though...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jacereda jacereda mentioned this pull request Jan 10, 2019
Closed
@endgame endgame mentioned this pull request Jan 14, 2019
Merged
10 tasks
@endgame
Copy link
Contributor

endgame commented Jan 14, 2019

I don't use purescript, but I'd really like to see that aeson fix get merged. Hopefully it happens soon.

@domenkozar
Copy link
Member

@GrahamcOfBorg build purescript

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/23

@jacereda
Copy link
Contributor Author

Sorry about the mess.
I rebased to current master because a fix for aeson already landed in master.

@domenkozar
Copy link
Member

@GrahamcOfBorg build purescript

@jacereda
Copy link
Contributor Author

Was the problem just a timeout? How do you see the full logs?

@marsam marsam mentioned this pull request Feb 19, 2019
Closed
@jacereda
Copy link
Contributor Author

Loos like @peti disabled the sphinx docs, should I rebase and reenable or leave it disabled?

@domenkozar
Copy link
Member

@GrahamcOfBorg build purescript

peti
peti requested changes Feb 21, 2019
View reviewed changes
pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix Outdated
@@ -45,7 +45,6 @@ self: super: {
unordered-containers = dontCheck super.unordered-containers;

# Test suite does not compile.
cereal = dontCheck super.cereal;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to purescript. It would be better to submit it in a separate PR, because this change is totally uncontroversial and it can be merged very quickly.

pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix Outdated
@@ -54,7 +53,6 @@ self: super: {
hpc-coveralls = doJailbreak super.hpc-coveralls; # https://github.com/guillaume-nargeot/hpc-coveralls/issues/82
http-api-data = doJailbreak super.http-api-data;
persistent-sqlite = dontCheck super.persistent-sqlite;
psqueues = dontCheck super.psqueues; # won't cope with QuickCheck 2.12.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

pkgs/development/haskell-modules/configuration-ghc-head.nix Outdated
@@ -60,7 +60,6 @@ self: super: {
hpc-coveralls = doJailbreak super.hpc-coveralls; # https://github.com/guillaume-nargeot/hpc-coveralls/issues/82
http-api-data = doJailbreak super.http-api-data;
persistent-sqlite = dontCheck super.persistent-sqlite;
psqueues = dontCheck super.psqueues; # won't cope with QuickCheck 2.12.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

pkgs/top-level/haskell-packages.nix Outdated
@@ -3,6 +3,18 @@
}:

let
# sphinx update to 1.8.x broke ghc versions < 8.6
sphinx_1_7_9 = buildPackages.python3Packages.sphinx.overridePythonAttrs (o:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the old Sphinx version into python-packages.nix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@peti
Copy link
Member

peti commented Feb 21, 2019

Loos like @peti disabled the sphinx docs, should I rebase and reenable or leave it disabled?

It's preferable to build the docs, obviously, so if your fix works properly then please re-base it. I have also added a couple of other comments in my review.

@jacereda
Copy link
Contributor Author

#56136
#56137
#56138
#56139

@peti peti changed the base branch from master to haskell-updates February 21, 2019 11:18
@peti
Copy link
Member

peti commented Feb 21, 2019

Test builds will be running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates ... I'll merge to master once these come back successfully.

@peti peti merged commit 62026b3 into NixOS:haskell-updates Feb 21, 2019
@peti
Copy link
Member

peti commented Feb 21, 2019

This PR broke all ghc-8.2.2 and 8.4.4 builds: https://hydra.nixos.org/eval/1506062. I have reverted it from haskell-updates.

@jacereda
Copy link
Contributor Author

Doh! Sorry, try again please.

@jacereda
Copy link
Contributor Author

This is the new PR: #56162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jacereda @endgame @domenkozar @nixos-discourse @ryantm @marsam @peti @GrahamcOfBorg