Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-music-scripts: init at 3.0.0 #53782

Merged
merged 11 commits into from Jan 20, 2019
Merged

google-music-scripts: init at 3.0.0 #53782

merged 11 commits into from Jan 20, 2019

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jan 10, 2019

Motivation for this change

Add google-music-scripts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbaum98 jbaum98 requested a review from FRidh as a code owner January 10, 2019 23:16
@jbaum98 jbaum98 force-pushed the google-music-scripts branch 3 times, most recently from 4a18cfe to 920913c Compare January 12, 2019 04:46
@jbaum98 jbaum98 changed the title google-music-scripts: init at 2.0.0 google-music-scripts: init at 3.0.0 Jan 15, 2019
@jbaum98
Copy link
Contributor Author

jbaum98 commented Jan 17, 2019

@worldofpeace Now that google-music-scripts has been updated to allow click version 7, I think this is ready to go.

@worldofpeace
Copy link
Contributor

@worldofpeace Now that google-music-scripts has been updated to allow click version 7, I think this is ready to go.

Nice, I'll give this a final review to see if there's anything amiss.

@worldofpeace
Copy link
Contributor

Looks like 6bc8ca7 had a little fixup mishap

@jbaum98
Copy link
Contributor Author

jbaum98 commented Jan 18, 2019

So if a package has no tests we want to explicitly disable checkPhase?

@worldofpeace
Copy link
Contributor

So if a package has no tests we want to explicitly disable checkPhase?

Yep. Other python maintainers here also agree on this.

worldofpeace
worldofpeace approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's good 👍
Thanks for your patience @jbaum98

Haven't tested the actual function of the program though.

I'll merge this with the approval of one more maintainer and If someone can vouch for the function.

cc @dotlambda

@worldofpeace
Copy link
Contributor

Note, if I don't get another approval within <24hrs I'll just merge it.

dotlambda
dotlambda requested changes Jan 18, 2019
View reviewed changes
pkgs/development/python-modules/audio-metadata/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/bidict/default.nix Outdated
};

# hypothesis-pytest is not needed
patches = [ ./hypothesis_pytest.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer doing this in postPatch using substituteInPlace.
Did you submit a patch upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a PR, but I actually realized that it's building without the patch.

pkgs/development/python-modules/google-music-proto/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/google-music-utils/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/google-music-utils/default.nix Show resolved Hide resolved
pkgs/development/python-modules/google-music/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pprintpp/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

dotlambda commented Jan 18, 2019 •
edited

I can confirm that google-music-scripts is functioning correctly.

This was referenced Jan 18, 2019
Merged
Merged
dotlambda
dotlambda requested changes Jan 18, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the patch files.

pkgs/development/python-modules/pprintpp/default.nix Outdated Show resolved Hide resolved
@worldofpeace worldofpeace merged commit 7e24c25 into NixOS:master Jan 20, 2019
@worldofpeace
Copy link
Contributor

Maybe a little more than 24 hours 🤣

@jbaum98
Copy link
Contributor Author

jbaum98 commented Jan 20, 2019

No problem, thanks @worldofpeace and @dotlambda for your help!

@jbaum98 jbaum98 deleted the google-music-scripts branch January 20, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@dotlambda dotlambda dotlambda requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbaum98 @worldofpeace @dotlambda @jtojnar @GrahamcOfBorg