Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start multi-user.target on deploy #1078

Closed
wants to merge 1 commit into from
Closed

Start multi-user.target on deploy #1078

wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jan 11, 2019

Fixes #1063.

This makes nixops deploy congruent (the declared services
will always be running after deploy, no matter what the state
of the server was before the deploy).

@nh2
Start multi-user.target on deploy. Fixes NixOS#1063.
83a0e9b 
This makes `nixops deploy` congruent (the declared services
will always be running after deploy, no matter what the state
of the server was before the deploy).
@nh2 nh2 mentioned this pull request Jan 11, 2019
Open
@grahamc
Copy link
Member

grahamc commented Jan 11, 2019

Should the NixOS activation script do it, instead?

@nh2
Copy link
Contributor Author

nh2 commented Jan 11, 2019

@grahamc I asked that too on #1063 (comment), but I can't easily tell if this would be too much of a change for non-NixOps NixOS (desktop) users.

@deepfire
Copy link
Contributor

@grahamc, anything can be done to move this forward?

@AmineChikhaoui
Copy link
Member

@deepfire I'm not sure if it's the job of Nixops to handle this. Nixops calls switch-to-configuration and that's where this should be handled imo.

@deepfire
Copy link
Contributor

@AmineChikhaoui, @grahamc, do we have a Nixpkgs issue to discuss this change of switch-to-configuration?

@AmineChikhaoui
Copy link
Member

@deepfire Not that I'm aware of.

@grahamc
Copy link
Member

grahamc commented Mar 26, 2020

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham

@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixops deploy doesn't bring server in desired state because it doesn't start stopped systemd units
4 participants
@nh2 @grahamc @deepfire @AmineChikhaoui