New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clightning: 0.6.2 -> 0.6.3 #53732
clightning: 0.6.2 -> 0.6.3 #53732
Conversation
3345852
to
7c87ac5
Compare
cc @roconnor not sure who else to ping here 😅 |
|
||
with stdenv.lib; | ||
stdenv.mkDerivation rec { | ||
name = "clightning-${version}"; | ||
version = "0.6.2"; | ||
version = "0.6.3"; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be using the official release zips now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nm the zip releases are broken atm
Doesn't work for me for the same reason as the test builder https://github.com/NixOS/nixpkgs/pull/53732/checks?check_run_id=48749093. (Quite confusing that github wrongly says "All checks have passed") |
@jonasnick hmm weird, for some reason worked for me... fixing... |
@grahamc for some reason the |
7c87ac5
to
4f1a16f
Compare
[0.6.3] - 2019-01-09: "The Smallblock Conspiracy" This release named by @molxyz and @ctrlbreak Added - JSON API: New command `check` checks the validity of a JSON API call without running it. - JSON API: `getinfo` now returns `num_peers` `num_pending_channels`, `num_active_channels` and `num_inactive_channels` fields. - JSON API: use `\n\n` to terminate responses, for simplified parsing (pylightning now relies on this) - JSON API: `fundchannel` now includes an `announce` option, when false it will keep channel private. Defaults to true. - JSON API: `listpeers`'s `channels` now includes a `private` flag to indicate if channel is announced or not. - Plugins: experimental plugin support for `lightningd`, including option passthrough and JSON-RPC passthrough. Changed - JSON API: `pay` and `decodepay` accept and ignore `lightning:` prefixes. - pylightning: Allow either keyword arguments or positional arguments. - JSON-RPC: messages are now separated by 2 consecutive newlines. - JSON-RPC: `jsonrpc`:`2.0` now included in json-rpc command calls. complies with spec. Deprecated Note: You should always set `allow-deprecated-apis=false` to test for changes. - pylightning: Support for pre-2-newline JSON-RPC (<= 0.6.2 lightningd) is deprecated. Removed - option_data_loss_protect is now only offered if EXPERIMENTAL_FEATURES is enabled, since it seems incompatible with lnd and has known bugs. Fixed - JSON API: uppercase invoices now parsed correctly (broken in 0.6.2). - JSON API: commands are once again read even if one hasn't responded yet (broken in 0.6.2). - Protocol: allow lnd to send `update_fee` before `funding_locked`. - Protocol: fix limit on how much funder can send (fee was 1000x too small) - Protocol: don't send invalid onion errors if peer says onion was bad. - Protocol: don't crash when peer sends a 0-block-expiry HTLC. - pylightning: handle multiple simultanous RPC replies reliably.
4f1a16f
to
ca67e65
Compare
since github screwed up the range-diff, here's v1 -> v2 1: 114dd7ab3e0 ! 1: e767a781d7b clightning: 0.6.2 -> 0.6.3
@@ -58,31 +58,43 @@
@@
{ stdenv, python3, pkgconfig, which, libtool, autoconf, automake,
- autogen, sqlite, gmp, zlib, fetchFromGitHub, fetchpatch }:
-+ autogen, sqlite, gmp, zlib, fetchFromGitHub, git }:
++ autogen, sqlite, gmp, zlib, fetchzip }:
with stdenv.lib;
stdenv.mkDerivation rec {
name = "clightning-${version}";
- version = "0.6.2";
-+ version = "0.6.3";
-
- src = fetchFromGitHub {
- fetchSubmodules = true;
- owner = "ElementsProject";
- repo = "lightning";
- rev = "v${version}";
+-
+- src = fetchFromGitHub {
+- fetchSubmodules = true;
+- owner = "ElementsProject";
+- repo = "lightning";
+- rev = "v${version}";
- sha256 = "18yns0yyf7kc4p4n1crxdqh37j9faxkx216nh2ip7cxj4x8bf9gx";
-+ sha256 = "1c50z7f75m55mjcy6j9wwsv8s4mdmjxlzyal7zqx0a6yaqmq5ccz";
++ version = "0.6.3";
++
++ src = fetchzip {
++ #
++ # NOTE 0.6.3 release zip was bugged, this zip is a fix provided by the team
++ # https://github.com/ElementsProject/lightning/issues/2254#issuecomment-453791475
++ #
++ # replace url with:
++ # https://github.com/ElementsProject/lightning/releases/download/v${version}/clightning-v${version}.zip
++ # for future relases
++ #
++ url = "https://github.com/ElementsProject/lightning/files/2752675/clightning-v0.6.3.zip";
++ sha256 = "0k5pwimwn69pcakiq4a7qnjyf4i8w1jlacwrjazm1sfivr6nfiv6";
};
enableParallelBuilding = true;
-
-- nativeBuildInputs = [ autoconf autogen automake libtool pkgconfig which ];
-+ nativeBuildInputs = [ git autoconf autogen automake libtool pkgconfig which ];
+@@
+ nativeBuildInputs = [ autoconf autogen automake libtool pkgconfig which ];
buildInputs = [ sqlite gmp zlib python3 ];
- makeFlags = [ "prefix=$(out)" ];
-@@
+- makeFlags = [ "prefix=$(out)" ];
++ makeFlags = [ "prefix=$(out) VERSION=v${version}" ];
+
+ configurePhase = ''
./configure --prefix=$out --disable-developer --disable-valgrind
'';
|
awesome, that works |
Is there a way to prioritize a merge? This fixes a remote DoS which is a coin stealing vulnerability in the Lightning security model. |
@GrahamcOfBorg build clightning |
backport:
|
backported here: #54001
let me know if I did this right
|
Added
check
checks the validity of a JSON API call without running it.getinfo
now returnsnum_peers
num_pending_channels
,num_active_channels
andnum_inactive_channels
fields.\n\n
to terminate responses, for simplified parsing (pylightning now relies on this)fundchannel
now includes anannounce
option, when false it will keep channel private. Defaults to true.listpeers
'schannels
now includes aprivate
flag to indicate if channel is announced or not.lightningd
, including option passthrough and JSON-RPC passthrough.Changed
pay
anddecodepay
accept and ignorelightning:
prefixes.jsonrpc
:2.0
now included in json-rpc command calls. complies with spec.Deprecated
Note: You should always set
allow-deprecated-apis=false
to test forchanges.
Removed
Fixed
update_fee
beforefunding_locked
.Signed-off-by: William Casarin jb55@jb55.com
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)