Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nicotine-plus: init at 1.4.1 #53717

Merged
merged 7 commits into from Feb 6, 2019
Merged

nicotine-plus: init at 1.4.1 #53717

merged 7 commits into from Feb 6, 2019

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Jan 9, 2019 •
edited

Motivation for this change

https://github.com/Nicotine-Plus/nicotine-plus
Would be nice to have it.

Also, maybe it's a good idea to pin dependencies to specific versions?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@6AA4FD 6AA4FD mentioned this pull request Jan 14, 2019
Closed
10 tasks
@6AA4FD
Copy link
Contributor

6AA4FD commented Jan 14, 2019

I wrote an expression for this, but it's less polished than yours, so I'm recommending yours be merged instead.
Builds and runs with nix with Gentoo. Might be a good idea to pin specific versions because the last commit was in February, and the last release with a few months before that, the maintainer(s) may not be keeping up with the libraries it uses.

@klntsky
Copy link
Member Author

klntsky commented Jan 14, 2019 •
edited

@6AA4FD

Might be a good idea to pin specific versions

I think so too. However, it's up to core maintainers to decide (I couldn't find any note on their policy regarding pinned versions anywhere).

@veprbl
Copy link
Member

veprbl commented Feb 6, 2019

@GrahamcOfBorg build nicotine-plus

veprbl
veprbl approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit 45fa569 into NixOS:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klntsky @6AA4FD @veprbl @GrahamcOfBorg