Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxslt: add libgcrypt to buildInputs for cryptoSupport #53346

Merged
merged 1 commit into from Jan 3, 2019
Merged

libxslt: add libgcrypt to buildInputs for cryptoSupport #53346

merged 1 commit into from Jan 3, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented Jan 3, 2019

Motivation for this change

I use the crypto:sha() extension function with xsltproc. It's not available without libgcrypt. libxslt configure even complains about it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Jan 3, 2019

I don't think there are any conflicts (in our expressions or due to changes in the package itself), but FWIW bumping libxslt here: #53347

@Mic92 Mic92 merged commit 68a16fc into NixOS:master Jan 3, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 3, 2019

also fixed in c3d2-web

@astro astro deleted the libxslt-libgcrypt branch January 5, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astro @dtzWill @Mic92 @GrahamcOfBorg