SCI32: Stub out kRestartGame #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restarting was only supported in QfG4, GK1 and PQ4. Those three used makeshift script code. The kernel call was stubbed out in SSCI as well. Fixes bug #10681.
|
I don't see a problem with it. |
|
I'm thinking maybe we should rename kRestartGame to kRestartGame16, just to clarify what's going on. We already have several other kernel functions using that convention. |
|
Fine by me. |
|
Agree with the change, and also agree to rename kRestartGame to kRestartGame16. Can you please add that change in this pull request, for completeness? |
|
@lskovlun |
|
Thanks, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting was only supported in QfG4, GK1 and PQ4. Those three used
makeshift script code. The kernel call was stubbed out in SSCI as
well. Fixes bug #10681.
I'm creating this pull request mainly because the kernel table entry for the SCI16 call changes as well.